Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Remove deprecate session service#41321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 5 commits intosymfony:6.0fromjderusse:deprec-session
Sep 7, 2021

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedMay 20, 2021
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

To ease code review this PR only removes code for session.

Blocked by#41343

@carsonbotcarsonbot added this to the6.0 milestoneMay 20, 2021
@jderussejderusse marked this pull request as draftMay 20, 2021 09:13
@jderussejderusseforce-pushed thedeprec-session branch 2 times, most recently fromc1b0432 to67cb63aCompareMay 20, 2021 16:42
@carsonbot

This comment has been minimized.

@carsonbotcarsonbot changed the titleRemove deprecate session service[FrameworkBundle] Remove deprecate session serviceMay 24, 2021
@nicolas-grekas
Copy link
Member

Rebase unlocked

@jderussejderusseforce-pushed thedeprec-session branch 4 times, most recently fromb7a5d3f tocb32334CompareMay 29, 2021 11:09
nicolas-grekas added a commit that referenced this pull requestJun 1, 2021
…r (jderusse)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Provide migration path for TestSessionListener| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -When working on#41321 I realized that#41343 was wrong for `TestSessionListener`.Injecting the factory in both SessionListener AND TestSessionListener would generate 2 distinguished session instances which is the opposite of the expected behavior: TestSessionListener needs the session used by the request to set the right sessionId in the cookie.This PR fallback to `request->getSession()` when there is no session injected in the container (ie: FrameworkBundlke:6)Commits-------b56606e Provide migration path for TestSessionListener
@fabpot
Copy link
Member

@jderusse Is it still in draft mode?

@jderussejderusseforce-pushed thedeprec-session branch 2 times, most recently fromed01205 to1d26674CompareJuly 4, 2021 15:49
@jderussejderusseforce-pushed thedeprec-session branch 5 times, most recently from7bccfce toe8d240bCompareJuly 5, 2021 06:00
@jderussejderusse marked this pull request as ready for reviewJuly 6, 2021 15:19
@jderusse
Copy link
MemberAuthor

💚 green

@jderussejderusseforce-pushed thedeprec-session branch 6 times, most recently from4ceb105 to2127454CompareSeptember 6, 2021 20:21
nicolas-grekas added a commit that referenced this pull requestSep 6, 2021
…nListener (jderusse)This PR was merged into the 5.4 branch.Discussion----------Make test.session.listener compatible with SF 6.0 SessionListener| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Fix flipped tests for#41321In Symfony 6.0, the session_listener does not use `session` service anymore, it needs a `session_factory` instead.note: the `session_listener` service is properly configured:https://github.com/symfony/symfony/blob/0d61de7576d0d6807924fada3df508c5d05d8f2f/src/Symfony/Bundle/FrameworkBundle/Resources/config/session.php#L146-L150Commits-------0943685 Make test.session.listener compatible with SF 6.0 SessionListener
@jderussejderusseforce-pushed thedeprec-session branch 2 times, most recently from3f9f3c1 tob2efa34CompareSeptember 6, 2021 21:58
jderusseand others added2 commitsSeptember 7, 2021 12:04
…re 6.0 (jderusse)This PR was merged into the 5.4 branch.Discussion----------Fix tests when security-http 5.4 uses security-core 6.0| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -see falling test in flipped tests for 6.0 branch:https://github.com/symfony/symfony/pull/41321/checks?check_run_id=3528227747#step:8:3572Commits-------58f09e5 Fix tests when security-http 5.4 uses security-core 6.0
nicolas-grekasand others added3 commitsSeptember 7, 2021 12:19
* 5.4:  cs fix  Fix tests when security-http 5.4 uses security-core 6.0
@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commit062ac36 intosymfony:6.0Sep 7, 2021
@jderussejderusse deleted the deprec-session branchSeptember 7, 2021 11:17
@fabpotfabpot mentioned this pull requestNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jderusse@carsonbot@nicolas-grekas@fabpot@stof@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp