Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Remove deprecate session service#41321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c1b0432 to67cb63aCompare This comment has been minimized.
This comment has been minimized.
nicolas-grekas commentedMay 27, 2021
Rebase unlocked |
b7a5d3f tocb32334Compare…r (jderusse)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Provide migration path for TestSessionListener| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -When working on#41321 I realized that#41343 was wrong for `TestSessionListener`.Injecting the factory in both SessionListener AND TestSessionListener would generate 2 distinguished session instances which is the opposite of the expected behavior: TestSessionListener needs the session used by the request to set the right sessionId in the cookie.This PR fallback to `request->getSession()` when there is no session injected in the container (ie: FrameworkBundlke:6)Commits-------b56606e Provide migration path for TestSessionListener
fabpot commentedJul 4, 2021
@jderusse Is it still in draft mode? |
ed01205 to1d26674Comparesrc/Symfony/Component/HttpFoundation/Session/Storage/ServiceSessionFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
7bccfce toe8d240bComparejderusse commentedJul 6, 2021
💚 green |
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpKernel/EventListener/AbstractTestSessionListener.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
1ce3641 to08ab7c3Comparesrc/Symfony/Component/Security/Http/Tests/Firewall/ContextListenerTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
4ceb105 to2127454Compare…nListener (jderusse)This PR was merged into the 5.4 branch.Discussion----------Make test.session.listener compatible with SF 6.0 SessionListener| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Fix flipped tests for#41321In Symfony 6.0, the session_listener does not use `session` service anymore, it needs a `session_factory` instead.note: the `session_listener` service is properly configured:https://github.com/symfony/symfony/blob/0d61de7576d0d6807924fada3df508c5d05d8f2f/src/Symfony/Bundle/FrameworkBundle/Resources/config/session.php#L146-L150Commits-------0943685 Make test.session.listener compatible with SF 6.0 SessionListener
3f9f3c1 tob2efa34Compare…re 6.0 (jderusse)This PR was merged into the 5.4 branch.Discussion----------Fix tests when security-http 5.4 uses security-core 6.0| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -see falling test in flipped tests for 6.0 branch:https://github.com/symfony/symfony/pull/41321/checks?check_run_id=3528227747#step:8:3572Commits-------58f09e5 Fix tests when security-http 5.4 uses security-core 6.0
* 5.4: cs fix Fix tests when security-http 5.4 uses security-core 6.0
81ea580 to9e6a3d3Comparenicolas-grekas commentedSep 7, 2021
Thank you@jderusse. |
Uh oh!
There was an error while loading.Please reload this page.
To ease code review this PR only removes code for session.
Blocked by#41343