Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Removed deprecated code#41319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4a10dfa tob4b48c1Compare
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you have a look at the Psalm errors regardingAbstractFailedMessagesCommand?
src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1f46605 to39d0234CompareNyholm commentedMay 23, 2021
The PR is updated and rebased. |
Nyholm commentedMay 23, 2021
Status: needs review |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
This PR was merged into the 6.0 branch.Discussion----------[Messenger] remove legacy code paths| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Should make tests green. (and missed in#41319)Commits-------6d65673 [Messenger] remove legacy code paths
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedJun 28, 2021
Rebase needed! |
8d103bb tod328c1fCompare
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PR is updated and rebased.
Status: needs review
Uh oh!
There was an error while loading.Please reload this page.
2781c25 to49d5ef7Comparesrc/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
8a2ccba to3b70e2dComparenicolas-grekas commentedJul 11, 2021
Thank you@Nyholm. |
Nyholm commentedJul 11, 2021
Thank you for merging |
This PR was squashed before being merged into the 5.2 branch.Discussion----------[Messenger] Fixed BC layer for RedeliveryStamp| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | no| New feature? | no| Deprecations? | yes| Tickets | Related to#41319 (comment)| License | MIT| Doc PR | n/aIn Symfony 6, the second argument to RedeliveryStamp's constructor will be a DateTimeInterface. We should already allow people to instantiate this object with the Symfony 6 way.Commits-------ac3c4d7 [Messenger] Fixed BC layer for RedeliveryStamp
…t` config option (andrew-demb)This PR was merged into the 6.0 branch.Discussion----------[Messenger] Remove mention to unsupported `prefetch_count` config option<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `6.x` for features of unreleased versions).-->`prefetch_count` was removed insymfony/symfony#41319Commits-------b8602c4 Remove mention to unsupported `prefetch_count` config option
Uh oh!
There was an error while loading.Please reload this page.
This remove deprecated code from Messenger.
TODO