Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Removed deprecated code#41319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Nyholm
Copy link
Member

@NyholmNyholm commentedMay 20, 2021
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

This remove deprecated code from Messenger.

TODO

  • Write changelog

@NyholmNyholm requested a review fromsroze as acode ownerMay 20, 2021 07:29
@carsonbotcarsonbot added this to the6.0 milestoneMay 20, 2021
@NyholmNyholmforce-pushed the6.0-messenger-deprecated branch 4 times, most recently from4a10dfa tob4b48c1CompareMay 20, 2021 20:13
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you have a look at the Psalm errors regardingAbstractFailedMessagesCommand?

@NyholmNyholmforce-pushed the6.0-messenger-deprecated branch 2 times, most recently from1f46605 to39d0234CompareMay 23, 2021 16:39
@Nyholm
Copy link
MemberAuthor

The PR is updated and rebased.

@Nyholm
Copy link
MemberAuthor

Status: needs review

nicolas-grekas added a commit that referenced this pull requestMay 27, 2021
This PR was merged into the 6.0 branch.Discussion----------[Messenger] remove legacy code paths| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Should make tests green. (and missed in#41319)Commits-------6d65673 [Messenger] remove legacy code paths
@nicolas-grekas
Copy link
Member

Rebase needed!

@NyholmNyholmforce-pushed the6.0-messenger-deprecated branch 2 times, most recently from8d103bb tod328c1fCompareJuly 11, 2021 17:01
Copy link
MemberAuthor

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PR is updated and rebased.

Status: needs review

@NyholmNyholmforce-pushed the6.0-messenger-deprecated branch from8a2ccba to3b70e2dCompareJuly 11, 2021 17:38
@nicolas-grekas
Copy link
Member

Thank you@Nyholm.

@nicolas-grekasnicolas-grekas merged commit8c17e63 intosymfony:6.0Jul 11, 2021
@NyholmNyholm deleted the 6.0-messenger-deprecated branchJuly 11, 2021 17:55
@Nyholm
Copy link
MemberAuthor

Thank you for merging

nicolas-grekas added a commit that referenced this pull requestJul 11, 2021
This PR was squashed before being merged into the 5.2 branch.Discussion----------[Messenger] Fixed BC layer for RedeliveryStamp| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | Related to#41319 (comment)| License       | MIT| Doc PR        | n/aIn Symfony 6, the second argument to RedeliveryStamp's constructor will be a DateTimeInterface. We should already allow people to instantiate this object with the Symfony 6 way.Commits-------ac3c4d7 [Messenger] Fixed BC layer for RedeliveryStamp
@fabpotfabpot mentioned this pull requestNov 5, 2021
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestDec 23, 2021
…t` config option (andrew-demb)This PR was merged into the 6.0 branch.Discussion----------[Messenger] Remove mention to unsupported `prefetch_count` config option<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `6.x` for features of unreleased versions).-->`prefetch_count` was removed insymfony/symfony#41319Commits-------b8602c4 Remove mention to unsupported `prefetch_count` config option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus requested changes

@chalasrchalasrchalasr left review comments

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Nyholm@nicolas-grekas@derrabus@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp