Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Remove deprecated code#41318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.0fromyceruto:form_remove_depr
May 31, 2021

Conversation

@yceruto
Copy link
Member

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

@yceruto
Copy link
MemberAuthor

I will continue with the rest tomorrow if no one takes care of it before. Cheers!

@ycerutoycerutoforce-pushed theform_remove_depr branch 2 times, most recently fromc4ee93d toda0f36fCompareMay 20, 2021 21:42
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please apply the CS fix suggested by Fabbot. Other than that, I'm happy with the changes. 👍🏻

@yceruto
Copy link
MemberAuthor

I fixed the issue spotted by fabbot.io (the last one is a false positive)

@nicolas-grekas
Copy link
Member

(rebase needed)

@yceruto
Copy link
MemberAuthor

(rebased)

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please check psalm reports and let us know if we they're false positive or not?
Please rebase also

@yceruto
Copy link
MemberAuthor

Can you please check psalm reports and let us know if we they're false positive or not?

It looks like a false positive for me.

(rebased)

nicolas-grekas reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@yceruto.

@nicolas-grekasnicolas-grekas merged commitd1be34d intosymfony:6.0May 31, 2021
@ycerutoyceruto deleted the form_remove_depr branchMay 31, 2021 16:29
@fabpotfabpot mentioned this pull requestNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yceruto@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp