Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[OptionsResolver] Remove deprecated code#41316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto commentedMay 20, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you
derrabus commentedMay 20, 2021
Can you please rebase to see if the CI turns green then? |
d5d70c8 to906e757Compare| { | ||
| $this->expectException(UndefinedOptionsException::class); | ||
| $this->resolver->setDeprecated('foo'); | ||
| $this->resolver->setDeprecated('foo','vendor/package','1.1'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
these could be worth fixing in 5.2,PR welcome
nicolas-grekas commentedMay 23, 2021
Thank you@yceruto. |