Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[EventDispatcher] Remove LegacyEventDispatcherProxy#41304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedMay 20, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
| 6.0 | ||
| --- | ||
| * Remove`LegacyEventDispatcherProxy` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shall we use a short sentence like this in code removal? Or duplicate the message inUPGRADE-6.0.md that also contains theUse the ... instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In this particular case, I don't think that anything beyond the note about the removal is helpful. That class is just plain obsolete now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When we have one, mentioning the replacement in the removal' UPGRADE instruction is good yes
846d667 to42feaf5Comparenicolas-grekas commentedMay 23, 2021
Maybe worth fixing the psalm report in this PR? |
…ter)This PR was merged into the 6.0 branch.Discussion----------[EventDispatcher] Removed deprecated code| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no| Deprecations? | yes| Tickets | -| License | MIT| Doc PR | -This remove deprecated code from EventDispatcher.The `LegacyEventDispatcherProxy` is removed in#41304.Is it necessary to update the Changelog or Upgrade.md that the classes are not configurable any more?Commits-------70b8b16 [EventDispatcher] Removed deprecated code
394be53 to117516cComparederrabus commentedMay 23, 2021
That's a good catch from Psalm. Since EventDispatcher has been bumped to 5.4 everywhere, we can safely drop the calls to |
117516c to5054709Comparenicolas-grekas commentedMay 23, 2021
Thank you@derrabus. |