Hey!

I think@fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

SwitchUserToken has no unserializer

test failure look related

It is indeed.

The failing test checks if aSwitchUserToken that has been serialized with Symfony 4.4 and PHP 7.2 (I think) can still be unserialized. This does not work anymore because on PHP 7.2, theSerializable interface is used and if we remove that interface, PHP does not know how to unserialize the data. The test will fail again if we remove the deprecatedUser class because the serialized fixture uses it.

I think, the gap is too large here. I would not expect that I can jump from Symfony 4.4 and PHP 7.2 to Symfony 6.0 and PHP 8.0 directly and resume old sessions.

I would regenerate the fixture withInMemoryUser on Symfony 5.3 and PHP 8 and update the test accordingly. Would that be okay?

🤔 Let's get that deprecated user out of that fixture first.#41385

Now that the deprecated fixture is out of the way, I could regenerate the fixture on PHP 8. This way, an app could still jump from Symfony 4.4 to 6.0 directly, if PHP is not upgraded at the same time. I'm going to document this is the upgrade notes.

Route has no unserializer

one more :)

one more :)

Fixed. I regenerated the fixture with Symfony 4.4 and PHP 8:

$newFixture =serialize(unserialize($oldFixture));

What is the use-case for serializing routes? I'd like to write an upgrade note here as well.

I think Drupal stores the routes in the DB.

Oh, I see. In that case, Drupal needs to provide a way to migrate database tables storing serialized routes after a PHP upgrade (if that does not happen already), ideally before they release a version with Symfony 6 support. Is there someone we can contact about that?

/cc@alexpott

As discussed in#41094 (comment), we should keep the interface on implementations (not on interfaces), but they should be final and internal, and only unserialize() should have an implementation: serialize() should throw a BadMethodCall instead

Thank you@derrabus.

Thank you for resuming my work. 🙂