Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Remove deprecation in slack-notifier#41298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jschaedl commentedMay 19, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
jderusse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wonder if we should also remove this code
symfony/src/Symfony/Component/Notifier/Bridge/Slack/SlackTransportFactory.php
Lines 34 to 36 ina2c8e84
| if ('/' !==$dsn->getPath() &&null !==$dsn->getPath()) { | |
| thrownewIncompleteDsnException('Support for Slack webhook DSN has been dropped since 5.2 (maybe you haven\'t updated the DSN when upgrading from 5.1).'); | |
| } |
jschaedl commentedMay 20, 2021
I think that make sense. This is missing an entry in the changelog of 5.2 too. Shall I add that entry in a separate PR against 5.2? |
jschaedl commentedMay 20, 2021
I checked it again. It's probably this entry:https://github.com/symfony/symfony/blame/4bf9461d9b0d2ee6840f4e3873542f8b54a5f8f4/src/Symfony/Component/Notifier/Bridge/Slack/CHANGELOG.md#L21 |
This PR was merged into the 5.2 branch.Discussion----------[Notifier] Add missing deprecation entry| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | <!-- required for new features -->follow-up on#41298Commits-------257d9ba Add missing deprecation entry
Uh oh!
There was an error while loading.Please reload this page.
| 6.0 | ||
| --- | ||
| * Remove`SlackOptions::channel()`, use`SlackOptions::recipient()` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no final dot please
3abdf63 to1c7d5b9Comparenicolas-grekas commentedMay 23, 2021
Thank you@jschaedl. |
This PR was merged into the 6.0 branch.Discussion----------[Mime] Remove symfony/deprecation-contracts| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License | MIT| Doc PR | - <!-- required for new features -->As commented here#41298 (comment) I removed `symfony/deprecation-contracts` as follow-up on#41364If the removal of `symfony/deprecation-contracts` is not important, I am happy to close this PR.Commits-------4a52a9b Remove symfony/deprecation-contracts