Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] Add support for getting updated context after a transition#41292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromlyrixx:workflow-marking-context
Jul 3, 2021

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedMay 19, 2021
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PR

I have a listener that lock the transition. Then, I need to give this
lock to my consumer. ATM, there is no easy way to pass a new resource
from a listener to the caller. I could add a newtmpLock property on my
subject (this is what I did temporary), but I'm not confortable with
this hack.

By adding the final context (it could be updated, that the point of
listener) to the marking, I could easily get data back.

Finally, the PHP doc of WorkflowInterface::apply() tells us:

 * @return Marking Thenew Marking

So I think it's legit to add also the new context

@carsonbot

This comment has been minimized.

@nicolas-grekasnicolas-grekas changed the title[Workflown] Add support for getting updated context after a transition[Workflow] Add support for getting updated context after a transitionMay 22, 2021
@nicolas-grekasnicolas-grekas added this to the5.4 milestoneMay 22, 2021
---

* Deprecate`InvalidTokenConfigurationException`
*Added`MermaidDumper` to dump Workflow graphs in the Mermaid.js flowchart format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please revert all unrelated changes here. We don't need/want to update all the old changelogs. The convention changed only for new entries.

}

/**
* Returns the context after the subject has transitionend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
* Returns the context after the subject hastransitionend.
* Returns the context after the subject hastransitioned.

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpotforce-pushed theworkflow-marking-context branch froma5052f8 to571c75eCompareJuly 3, 2021 05:28
@fabpotfabpot merged commit6402572 intosymfony:5.4Jul 3, 2021
@lyrixxlyrixx deleted the workflow-marking-context branchJuly 5, 2021 08:30
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx@carsonbot@fabpot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp