Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Lock] Remove deprecated classes in Lock#41284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
derrabus approved these changesMay 19, 2021
chalasr requested changesMay 19, 2021
Member
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need a CHANGELOG entry for removals :)
3fb16ec to33dfba2Comparederrabus approved these changesMay 19, 2021
358081b toe4dba8aComparechalasr approved these changesMay 21, 2021
Member
nicolas-grekas commentedMay 23, 2021
(rebase needed) |
MemberAuthor
jderusse commentedMay 23, 2021
rebased |
Member
nicolas-grekas commentedMay 23, 2021
WDYT of the failures? |
Member
nicolas-grekas commentedMay 23, 2021
Thank you@jderusse. |
Merged
derrabus added a commit that referenced this pull requestNov 20, 2021
…face (jderusse)This PR was merged into the 6.0 branch.Discussion----------[FrameworkBundle] Remove code relating to old StoreInterface| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -The interface has been remove in symfony/lock 5.0, (but FWB was still compatible with symfony/lock 4.4).Now FWB conflicts with <5.4 we can finally remove this referenceI also forgot to remove the `$lockDefinition` definition in#41284Commits-------a0a431c Remove code relating to old SotreInterface
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated paths in
Lockcomponent