Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Bump Symfony 6 to PHP 8#41282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Bump Symfony 6 to PHP 8#41282
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 19, 2021
Hey! But you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
fabpot commentedMay 19, 2021
Thank you@nicolas-grekas. |
Uh oh!
There was an error while loading.Please reload this page.
hacfi commentedMay 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just a note: there is an issue with PHP 8.0.5 and Postgresql which is why 8.0.6 was released. |
nicolas-grekas commentedMay 20, 2021
For the record, 8.0.2 was chosen as the minimum because that's the version that runs on Travis. |
derrabus commentedMay 20, 2021
8.0.2 is a reasonable requirement. We can still fine tune this before November, but a Postgres compat issue is not enough to block 8.0.5 imho. |
hacfi commentedMay 20, 2021
I'm also fine with 8.0.2. Just wanted to note this in case someone is setting up a project with 8.0.5 and then gets errors (happened to me recently). |
stof commentedMay 20, 2021
Well, in any case, therecommended version is always the uptodate patch release, to benefit from PHP bugfixes. This constraint is about the minimum version, not the recommended one. |
| -name:Install dependencies | ||
| run:| | ||
| echo "::group::fake PHP version" | ||
| composer config platform.php 8.0.99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We still need this, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR was merged into the 6.0 branch.Discussion----------Fake PHP version on PHP nightly builds| Q | A| ------------- | ---| Branch? | 6.0| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/AThese two lines have been removed in#41282. Unfortunately, we still need them because people set upper boundaries in their composer.json. Without lying to composer, we cannot install dependencies on PHP 8.1 (yet).Commits-------6d6ea6d Fake PHP version on PHP nightly builds
🎉