Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] Allow setting session options via DSN#41268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4frommakraz:redis-session-handler-options-issue
Oct 20, 2021
Merged

[HttpFoundation] Allow setting session options via DSN#41268

nicolas-grekas merged 1 commit intosymfony:5.4frommakraz:redis-session-handler-options-issue
Oct 20, 2021

Conversation

@makraz
Copy link
Contributor

@makrazmakraz commentedMay 18, 2021
edited
Loading

QA
Branch?5.4 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41071
LicenseMIT
Doc PRN/A

@nicolas-grekas
Copy link
Member

Thanks for the PR. This looks like a new feature to me. As such, that's for 5.4.
Looking at other handlers, they would too benefit from options.
Also,MemcachedSessionHandler usesexpiretime instead ofttl and defaults to 86400 instead ofini_get('session.gc_maxlifetime') 🤦
Can you please have a look and try to add some consistency there?
Don't forget to update the CHANGELOG of the component while doing so.
Thanks!

@nicolas-grekasnicolas-grekas added this to the5.x milestoneMay 18, 2021
@makraz
Copy link
ContributorAuthor

Thanks for the PR. This looks like a new feature to me. As such, that's for 5.4.
Looking at other handlers, they would too benefit from options.
Also,MemcachedSessionHandler usesexpiretime instead ofttl and defaults to 86400 instead ofini_get('session.gc_maxlifetime') 🤦
Can you please have a look and try to add some consistency there?
Don't forget to update the CHANGELOG of the component while doing so.
Thanks!

@nicolas-grekas thank you for the feedback. I updated the PR to let other handlers benefit from options.

@carsonbotcarsonbot changed the titleSet prefix/ttl in RedisSessionHandler settings via DSN[HttpFoundation] Set prefix/ttl in RedisSessionHandler settings via DSNJun 22, 2021
@nicolas-grekasnicolas-grekas changed the title[HttpFoundation] Set prefix/ttl in RedisSessionHandler settings via DSN[HttpFoundation] Allow setting session options via DSNJun 22, 2021
@nicolas-grekas
Copy link
Member

@makraz I force-pushed some changes on your fork. Could you please fetch it and add some test cases?

@makraz
Copy link
ContributorAuthor

@makraz, I force-pushed some changes on your fork. Could you please fetch it and add some test cases?

Thank you,@nicolas-grekas, for the update. I will work on the test cases

@nicolas-grekas
Copy link
Member

Friendly ping@makraz (rebase needed also)

@nicolas-grekas
Copy link
Member

Thank you@makraz.

makraz reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Btw, PR adding tests + another adding doc would be really welcomed.

makraz reacted with heart emoji

@makrazmakraz deleted the redis-session-handler-options-issue branchOctober 20, 2021 10:25
@makraz
Copy link
ContributorAuthor

makraz commentedOct 20, 2021
edited
Loading

Btw, PR adding tests + another adding doc would be really welcomed.

Thanks@nicolas-grekas for merging my PR, and sure I will handle it 🙌

This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@SergeShinSergeShinSergeShin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Session] Not possible to set prefix/ttl in RedisSessionHandler settings via DSN

4 participants

@makraz@nicolas-grekas@SergeShin@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp