Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Allow setting session options via DSN#41268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[HttpFoundation] Allow setting session options via DSN#41268
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/SessionHandlerFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedMay 18, 2021
Thanks for the PR. This looks like a new feature to me. As such, that's for 5.4. |
makraz commentedMay 19, 2021
@nicolas-grekas thank you for the feedback. I updated the PR to let other handlers benefit from options. |
nicolas-grekas commentedJun 22, 2021
@makraz I force-pushed some changes on your fork. Could you please fetch it and add some test cases? |
makraz commentedJun 23, 2021
Thank you,@nicolas-grekas, for the update. I will work on the test cases |
nicolas-grekas commentedSep 8, 2021
Friendly ping@makraz (rebase needed also) |
nicolas-grekas commentedOct 20, 2021
Thank you@makraz. |
nicolas-grekas commentedOct 20, 2021
Btw, PR adding tests + another adding doc would be really welcomed. |
makraz commentedOct 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks@nicolas-grekas for merging my PR, and sure I will handle it 🙌 |
Uh oh!
There was an error while loading.Please reload this page.