Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SecurityBundle] Change information label from red to yellow#41242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:5.2from94noni:patch-1
Jun 27, 2021

Conversation

@94noni
Copy link
Contributor

QA
Branch?5.x
Bug fix?no
New feature?no
Deprecations?no
Tickets.
LicenseMIT
Doc PR.

The red colour feels like an error, but being not authenticated is more like a warning (generally associated with yellow/orange) than an error (generally in red).
Feel free to close, cheers :)

@wouterj
Copy link
Member

Are you by any chance using the new authenticator system (enable_authenticator_manager: true)? I think that messed up this color (you can see "not authenticated" being defined as yellow for the old system on line 8).
If so, we probably should do this only for the new system. In that case, let's wait on#41139 to be merged as it introduces a way to detect which system is used in the data collector.

ismail1432 reacted with thumbs up emoji

@wouterjwouterj modified the milestones:5.x,5.2May 16, 2021
@94noni
Copy link
ContributorAuthor

94noni commentedMay 16, 2021
edited
Loading

@wouterj let me check and I’ll report back soon
Lets wait for now :)

edit: yes indeed my project uses the new security system

@pavol-tuka
Copy link
Contributor

pavol-tuka commentedJun 18, 2021
edited
Loading

I think there should be no extra color if no firewall is matched, element should be black. Consider public website with no auth at all. Should by developer "warned" or "errored" if no firewall match is expected?

@wouterj
Copy link
Member

@pavol-tk if a firewall doesn't match, the security block isn't visible in the toolbar. The yellow color is shown when a firewall matches, but a user is not authenticated (this is currently red).

@pavol-tuka
Copy link
Contributor

pavol-tuka commentedJun 18, 2021
edited
Loading

@wouterj No firewall matched, and block is visible ...and red ... or am I missing something?

screen.mp4

@wouterj
Copy link
Member

Thank you@94noni!

@pavol-tk hmm, you're correct indeed. I agree with you and I've proposed a fix for this in#41874

94noni reacted with thumbs up emoji

@94noni94noni deleted the patch-1 branchJune 27, 2021 12:24
This was referencedJun 30, 2021
fabpot added a commit that referenced this pull requestJul 2, 2021
…matched (wouterj)This PR was merged into the 5.4 branch.Discussion----------[SecurityBundle] Hide security toolbar if no firewall matched| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#41242 (comment)| License       | MIT| Doc PR        | -As reported by `@pavol`-tk, we currently show a red Security block in the toolbar if no firewall matched. I think we should instead leave the block out of the toolbar, just like we do with all other elements if there is no data for that request.cc `@javiereguiluz` as you're the best in these UX like decisions :)Commits-------75590aa [SecurityBundle] Hide Security item if no firewall matched
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@94noni@wouterj@pavol-tuka@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp