Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Change information label from red to yellow#41242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedMay 16, 2021
Are you by any chance using the new authenticator system ( |
94noni commentedMay 16, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@wouterj let me check and I’ll report back soon edit: yes indeed my project uses the new security system |
pavol-tuka commentedJun 18, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think there should be no extra color if no firewall is matched, element should be black. Consider public website with no auth at all. Should by developer "warned" or "errored" if no firewall match is expected? |
wouterj commentedJun 18, 2021
@pavol-tk if a firewall doesn't match, the security block isn't visible in the toolbar. The yellow color is shown when a firewall matches, but a user is not authenticated (this is currently red). |
pavol-tuka commentedJun 18, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@wouterj No firewall matched, and block is visible ...and red ... or am I missing something? screen.mp4 |
wouterj commentedJun 27, 2021
…matched (wouterj)This PR was merged into the 5.4 branch.Discussion----------[SecurityBundle] Hide security toolbar if no firewall matched| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#41242 (comment)| License | MIT| Doc PR | -As reported by `@pavol`-tk, we currently show a red Security block in the toolbar if no firewall matched. I think we should instead leave the block out of the toolbar, just like we do with all other elements if there is no data for that request.cc `@javiereguiluz` as you're the best in these UX like decisions :)Commits-------75590aa [SecurityBundle] Hide Security item if no firewall matched
The red colour feels like an error, but being not authenticated is more like a warning (generally associated with yellow/orange) than an error (generally in red).
Feel free to close, cheers :)