Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Finder] Fix gitignore regex build with "**"#41241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frommvorisek:fix_gitignore_41223
May 16, 2021

Conversation

@mvorisek
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41223
LicenseMIT
Doc PRno

covered with tests, also faster, we do not have to explode the rule at all :)

ping@lindelius@OskarStark

lindelius reacted with thumbs up emojiOskarStark reacted with heart emoji
@derrabus
Copy link
Member

Thank your for your PR. Two questions:

  • Did you target the 5.x branch on purpose? The PR discription says you wanted to target 4.4.
  • Can we find a PR title that people would want to read in a ChangeLog? 🙂

@carsonbotcarsonbot changed the titleFix 41223 issue "**/vendor/**"[Finder] Fix 41223 issue "**/vendor/**"May 15, 2021
@mvorisekmvorisek changed the base branch from5.x to4.4May 15, 2021 18:44
@mvorisekmvorisek changed the title[Finder] Fix 41223 issue "**/vendor/**"[Finder] Fix gitignore with "**"May 15, 2021
@mvorisekmvorisek changed the title[Finder] Fix gitignore with "**"[Finder] Fix gitignore regex build with "**"May 15, 2021
@mvorisek
Copy link
ContributorAuthor

@derrabus base changed, it should be 4.4, title also updated

derrabus reacted with thumbs up emojiderrabus reacted with heart emoji

@mvorisekmvorisekforce-pushed thefix_gitignore_41223 branch 4 times, most recently from396c1b4 tod91eafbCompareMay 15, 2021 20:00
@lindelius
Copy link

I can confirm that this PR fixes the issue for us, at least. Thanks!

@fabpotfabpotforce-pushed thefix_gitignore_41223 branch fromd91eafb toce22d5dCompareMay 16, 2021 12:25
@fabpot
Copy link
Member

Thank you@mvorisek.

@fabpotfabpot merged commit03519d4 intosymfony:4.4May 16, 2021
@mvorisekmvorisek deleted the fix_gitignore_41223 branchMay 16, 2021 12:37
This was referencedMay 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

Symfony/finder no longer handles patterns like **/vendor/**

6 participants

@mvorisek@derrabus@lindelius@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp