Various built-in PHP functions will trigger a deprecation warning ifnull is passed as parameter. This PR attempts to fix all warnings that our test suite currently picks up.

derrabus requested review fromchalasr,wouterj andxabbuh ascode owners

May 15, 2021 17:21

carsonbot added Status: Needs Review Bug labels

May 15, 2021

carsonbot added this to the4.4 milestone

May 15, 2021

derrabus mentioned this pull request

May 15, 2021

[BrowserKit] Don't pass null to rawurlencode()#41236

Closed

derrabus force-pushed thebugfix/deprecated-null-parameters branch from5866fb1 to29df695Compare

May 15, 2021 17:24

nicolas-grekas reviewed

May 16, 2021

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, here is some nitpicking.
Maybe worth applying the fabpot patch also?

src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Finder/Comparator/NumberComparator.php OutdatedShow resolvedHide resolved

src/Symfony/Component/CssSelector/XPath/Extension/NodeExtension.php OutdatedShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php OutdatedShow resolvedHide resolved

src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.phpShow resolvedHide resolved

src/Symfony/Component/DependencyInjection/Compiler/RegisterServiceSubscribersPass.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Translation/Loader/XliffFileLoader.php OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

derrabus commentedMay 16, 2021

Maybe worth applying the fabpot patch also?

The Fabbot patch would break the PHP 5 compatibility of the PhpUnitBridge.

derrabus force-pushed thebugfix/deprecated-null-parameters branch from29df695 to8e8adc3Compare

May 16, 2021 09:34

Fixed deprecation warnings about passing null as parameter

7d9bdf5

derrabus force-pushed thebugfix/deprecated-null-parameters branch from8e8adc3 to7d9bdf5Compare

May 16, 2021 09:52

nicolas-grekas approved these changes

May 16, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

May 16, 2021

fabpot approved these changes

May 16, 2021

View reviewed changes

Copy link

Member

fabpot commentedMay 16, 2021

Thank you@derrabus.

fabpot merged commiteb3a3c1 intosymfony:4.4

May 16, 2021

derrabus deleted the bugfix/deprecated-null-parameters branch

May 16, 2021 13:27

This was referencedMay 19, 2021

Release v4.4.24#41278

Merged

Release v5.2.9#41279

Merged

Release v5.3.0-RC1#41283

Merged

derrabus mentioned this pull request

May 20, 2021

Fix PHP 8.1 deprecations#41348

Merged

nicolas-grekas added a commit that referenced this pull request

May 21, 2021

minor#41348Fix PHP 8.1 deprecations (derrabus)

3bb1ec3

This PR was merged into the 5.2 branch.Discussion----------Fix PHP 8.1 deprecations| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AFollow-up of#41240 on the 5.2 branchCommits-------fb99f93 Fix PHP 8.1 deprecations

derrabus mentioned this pull request

Jun 6, 2021

[Translation] Don't pass null to strtoupper()#41562

Merged

nicolas-grekas added a commit that referenced this pull request

Jun 6, 2021

minor#41562[Translation] Don't pass null to strtoupper() (derrabus)

b87de42

This PR was merged into the 4.4 branch.Discussion----------[Translation] Don't pass null to strtoupper()| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Part of#41552| License       | MIT| Doc PR        | N/AThis error popped up on 5.3, but not on 4.4. That's why I missed it when fixing the other occurrence with#41240.Commits-------3c8cf9a [Translation] Don't pass null to strtoupper()