Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Don't force AbstractController::handleForm() to return a Response#41184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMay 12, 2021•
edited by javiereguiluz
Loading

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

As noted by@lyrixx and@dunglas, forcing aResponse here is less flexible as eg it prevents using@Template and other kind of view listeners.

@lyrixx
Copy link
Member

this does not work: you can not set status code on something else than a response.
BTW, the current code is broken:https://github.com/symfony/symfony/blob/5.x/src/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.php#L317-L319

the check is done after the call tosetStatusCode

nicolas-grekas reacted with thumbs up emoji

@nicolas-grekas
Copy link
MemberAuthor

you can not set status code on something else than a response.

indeed, fixed!

@nicolas-grekas
Copy link
MemberAuthor

Closing as this doesn't solve the UX turbo concern and opens a new pattern that we should think more about.

@nicolas-grekasnicolas-grekas deleted the handle-form branchMay 12, 2021 07:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@lyrixx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp