Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Telnyx notifier bridge#41172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromStaffNowa:feature/telnyx
Jun 23, 2021
Merged

[Notifier] Add Telnyx notifier bridge#41172

fabpot merged 1 commit intosymfony:5.4fromStaffNowa:feature/telnyx
Jun 23, 2021

Conversation

@StaffNowa
Copy link
Contributor

@StaffNowaStaffNowa commentedMay 11, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#15377
Recipe PRsymfony/recipes#951

Telnyx notifierhttps://developers.telnyx.com/docs/v2/messaging/quickstarts/sending-sms-and-mms

@carsonbotcarsonbot changed the title[notifier] Add Telnyx notifier bridge[Notifier] Add Telnyx notifier bridgeMay 11, 2021
@nicolas-grekasnicolas-grekas added this to the5.x milestoneMay 11, 2021

where:
-`API_KEY` is your telnyx API key
-`FROM` is your sender. The phone number should start with a plus "%2B"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should validate this and throw a proper exception instead of documenting it

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Asked company about to have ability to test number + custom sender name, then I will make additional validation :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

image

If people wants to use sender name they need to have this option. Where better put this option? into env like sub option? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You mean you can add amessageProfileId and from there the company name is used as sender?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@OskarStark provider allow to have sender name likeSymfony (not phone number) if this option filled and correct :) Than I will need to put this option into .env file to access it :) messageProfileId unique by their account and can be regenerated :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updated

@StaffNowa
Copy link
ContributorAuthor

Added docs + recipes

OskarStark reacted with thumbs up emoji

@OskarStarkOskarStark requested review fromNyholm,chalasr,fabpot andjderusse and removed request forNyholm,chalasr andjderusseJune 17, 2021 09:18
@StaffNowa
Copy link
ContributorAuthor

Forgot about me? :))))

@OskarStark
Copy link
Contributor

We need another review and approval please

StaffNowa reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@StaffNowa.

OskarStark reacted with thumbs up emoji

@fabpotfabpot merged commit2fb272e intosymfony:5.4Jun 23, 2021
@StaffNowaStaffNowa deleted the feature/telnyx branchJune 23, 2021 12:05
fabpot added a commit that referenced this pull requestJun 27, 2021
…uild) (wouterj)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Fix Telnyx service registration (fixes build)| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This was missed in#41172 and caused the build to fail in 5.4 and 6.0Commits-------1044087 [FrameworkBundle] Fix Telnyx service registration
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@welcoMatticwelcoMatticwelcoMattic left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@jderussejderusseAwaiting requested review from jderusse

@NyholmNyholmAwaiting requested review from Nyholm

+1 more reviewer

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@StaffNowa@OskarStark@fabpot@welcoMattic@noniagriconomie@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp