Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] Override recipient with mailer.envelope.recipients configuration#41150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 9, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedMay 10, 2021
Hey! I think@Koc has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
| foreach ($envelope->getRecipients()as$key =>$recipient) { | ||
| if($key ===0) { | ||
| $originalMessage->to($recipient->getAddress()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For once, I'm going to agree with Psalm! The original message can be a RawMessage for which we don't have any of these conventional methods. In any case, the envelope should never alter the message directly.
This is controlled by line 199 instead.
trsteel88 commentedDec 11, 2021
Any update on this bug? |
arnolem commentedDec 12, 2021
|
fabpot commentedMar 18, 2022
Closing in favor of#45690 |
This PR was merged into the 4.4 branch.Discussion----------[Mailer] Use recipients in sendmail transport| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#41149| License | MIT| Doc PR | -Supersedes#41150Commits-------7134e46 [Mailer] Use recipients in sendmail transport
#41149
Symfony/Mailer : The recipients feature ("Always Send to the same Address") does not work with sendmail