Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Inflector][String] wrong plural form of words ending by "pectus"#41147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frommakraz:inflector-pluralize-issue
May 10, 2021
Merged

[Inflector][String] wrong plural form of words ending by "pectus"#41147

nicolas-grekas merged 1 commit intosymfony:4.4frommakraz:inflector-pluralize-issue
May 10, 2021

Conversation

@makraz
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41124
LicenseMIT
Doc PRN/A

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

I just have two small questions

['suc',3,true,true,'cuses'],

// conspectuses (conspectus), prospectuses (prospectus)
['sutcep',6,true,true,'pectuses'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if this line is removed, will the tests still pass?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no, the tests failed
image

@carsonbotcarsonbot changed the title[String] wrong plural form of words ending by "pectus"[Inflector][String] wrong plural form of words ending by "pectus"May 10, 2021
@nicolas-grekas
Copy link
Member

Thank you@makraz.

makraz reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit9c9e645 intosymfony:4.4May 10, 2021
@makrazmakraz deleted the inflector-pluralize-issue branchMay 10, 2021 14:38
This was referencedMay 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@makraz@nicolas-grekas@Nyholm@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp