Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] [DataCollector] Remove allows anonymous information in datacollector#41139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ismail1432
Copy link
Contributor

@ismail1432ismail1432 commentedMay 9, 2021•
edited by chalasr
Loading

QA
Branch?5.2
Bug fix?no
New feature?yes/no
Deprecations?yes/no
TicketsFix#40907
LicenseMIT
Doc PRsymfony/symfony-docs#...

As mentioned In#40907 there is no longer anonymous users no longer in the new authentication system. This PR remove this informationif the new system is used as it always a red cross

Withenable_authenticator_manager atfalse
image

Withenable_authenticator_manager attrue
image

MatTheCat and apfelbox reacted with thumbs up emoji
@carsonbotcarsonbot changed the title[Security][DataCollector] Remove allows anonymous information in datacollector[Security] [DataCollector] Remove allows anonymous information in datacollectorMay 9, 2021
@chalasr
Copy link
Member

Thanks for the PR.
I think this first has to be a bugfix for 5.2.

As you pointed out, this info is only relevant when the new authenticator system is not in use.
Could you update your patch to remove it only ifenable_authenticator_manager istrue? And revert the removal ofFirewallConfig::allowsAnonymous(), as it will need to be deprecated first when the old system will been removed (in 6.x).

wouterj and ismail1432 reacted with thumbs up emoji

@ismail1432
Copy link
ContributorAuthor

Thanks@chalasr for the feedback, Yes I'll do 👍

@chalasrchalasr added this to the5.2 milestoneMay 9, 2021
@ismail1432ismail1432force-pushed thesecurity-data-collector-remove-allow-anonymous branch from4a68e97 tob5f3e27CompareMay 17, 2021 10:47
@ismail1432ismail1432force-pushed thesecurity-data-collector-remove-allow-anonymous branch from9dc4460 to13b3cc1CompareMay 18, 2021 10:48
@chalasrchalasr changed the base branch from5.x to5.2May 18, 2021 10:57
@chalasrchalasr changed the base branch from5.2 to5.xMay 18, 2021 10:57
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for 5.2 (be careful when merging, target branch is incorrect)

@wouterjwouterj changed the base branch from5.x to5.2May 18, 2021 13:25
@ismail1432ismail1432 changed the base branch from5.2 to5.xMay 18, 2021 13:25
@wouterjwouterjforce-pushed thesecurity-data-collector-remove-allow-anonymous branch from13b3cc1 to92cd096CompareMay 18, 2021 13:25
@wouterjwouterj changed the base branch from5.x to5.2May 18, 2021 13:26
@wouterjwouterj merged commite83c992 intosymfony:5.2May 18, 2021
@wouterj
Copy link
Member

Thank you@ismail1432 for fixing the profiler & testing your changes :)

ismail1432 reacted with heart emoji

This was referencedMay 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@wouterjwouterjwouterj approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

[Security][Profiler] “Allows anonymous” always false with enable_authenticator_manager

6 participants

@ismail1432@chalasr@wouterj@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp