Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix return type in isAllowedProperty method on ReflectionExtractor class#41104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Tomanhez
Copy link
Contributor

@TomanhezTomanhez commentedMay 4, 2021•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41103
LicenseMIT
Doc PRsymfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't useboolval() in this codebase. Please apply the fix suggested by fabbot.

Can you also please add a failing test for your issue?

@derrabus
Copy link
Member

You opened a bugfix for 5.2, but you have created a PR for the 5.x branch. Can you please rebase and retarget your PR?

@TomanhezTomanhezforce-pushed thefix-reflection-extractor-is-allowed-property branch from4e2b404 to8c0e8f7CompareMay 4, 2021 13:54
@TomanhezTomanhez changed the base branch from5.x to5.2May 4, 2021 13:55
@Tomanhez
Copy link
ContributorAuthor

@derrabus I changedboolval for(bool) but with additional brackets and its work properly.

@fabpot
Copy link
Member

Thank you@Tomanhez.

@fabpotfabpot merged commit3f57255 intosymfony:5.2May 6, 2021
This was referencedMay 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

Method isAllowedProperty on ReflectionExtractor class can return int type

4 participants

@Tomanhez@carsonbot@derrabus@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp