Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarExporter] Add support of PHP enumerations#41072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedMay 2, 2021•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40237
LicenseMIT
Doc PRnone

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't expect this patch to be that simple, thanks for opening :)
Can you please rebase for 4.4? We consider support for newer PHP versions as a bug fix.

alexandre-daubois reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneMay 2, 2021
@nicolas-grekasnicolas-grekas added Bug and removed Feature labelsMay 2, 2021
@alexandre-dauboisalexandre-dauboisforce-pushed thefeat-var-exporter-enum-support branch 2 times, most recently from3a4c27c to9cf44c2CompareMay 3, 2021 11:10
@alexandre-dauboisalexandre-dauboisforce-pushed thefeat-var-exporter-enum-support branch from9cf44c2 tof204ccbCompareMay 3, 2021 11:29
@alexandre-dauboisalexandre-daubois changed the base branch from5.x to4.4May 3, 2021 11:29
@alexandre-dauboisalexandre-dauboisforce-pushed thefeat-var-exporter-enum-support branch 2 times, most recently fromd444cd1 toe4f0c5aCompareMay 3, 2021 12:49
@nicolas-grekasnicolas-grekas changed the title[VarExporter] Add support of PHP 8.1 enumerations[VarExporter] Add support of PHP enumerationsMay 6, 2021
@nicolas-grekasnicolas-grekasforce-pushed thefeat-var-exporter-enum-support branch frome4f0c5a to4b0f299CompareMay 6, 2021 19:18
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@nicolas-grekasnicolas-grekas merged commite51e651 intosymfony:4.4May 6, 2021
@alexandre-dauboisalexandre-daubois deleted the feat-var-exporter-enum-support branchMay 7, 2021 06:53
This was referencedMay 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[VarExporter] add support for Enums on PHP 8.1

4 participants

@alexandre-daubois@nicolas-grekas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp