Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Fix return SentMessage then Messenger not used#40982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@WaylandAce
Copy link
Contributor

@WaylandAceWaylandAce commentedApr 29, 2021•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
Tickets--
LicenseMIT
Doc PR--

#37748 Broke the Notifier when Transport not used.

@OskarStark
Copy link
Contributor

@jschaedl can you please have a look?

@jschaedl
Copy link
Contributor

@WaylandAce Can you please target 5.2 branch and make fabbot.io happy :-)

OskarStark and WaylandAce reacted with thumbs up emoji

@OskarStarkOskarStark added this to the5.2 milestoneApr 29, 2021
@WaylandAceWaylandAce changed the base branch from5.x to5.2April 29, 2021 16:45
@derrabus
Copy link
Member

I think we should add a test, so we don't break this again.

jschaedl and OskarStark reacted with thumbs up emoji

@WaylandAceWaylandAceforce-pushed thefix/notifier_null_sentmessage branch fromc288bb7 to9a2526dCompareMay 5, 2021 09:03
@WaylandAceWaylandAceforce-pushed thefix/notifier_null_sentmessage branch 4 times, most recently from0e13d25 to81a0dc5CompareMay 6, 2021 07:29
@WaylandAceWaylandAceforce-pushed thefix/notifier_null_sentmessage branch from81a0dc5 to4197af2CompareMay 6, 2021 16:53
Copy link
Contributor

@jschaedljschaedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Only 2 minor issues. The rest looks good to me 👍🏻

@WaylandAceWaylandAceforce-pushed thefix/notifier_null_sentmessage branch from4197af2 to82085deCompareMay 7, 2021 05:11
@WaylandAceWaylandAceforce-pushed thefix/notifier_null_sentmessage branch from82085de to1245114CompareMay 7, 2021 06:30
Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Before we can merge this PR, please addMIT to the License in the PR header, this should make Fabbot happy.

Thanks

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LICENSE added 👍

@OskarStark
Copy link
Contributor

Thank you Pavel for taking care of this regression.

jschaedl reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@jschaedljschaedljschaedl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

6 participants

@WaylandAce@OskarStark@jschaedl@derrabus@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp