NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Fixes for PHP 8.1 deprecations#40964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

derrabus merged 1 commit intosymfony:4.4fromjrmajor:php81/http-foundation

Apr 27, 2021

Merged

[HttpFoundation] Fixes for PHP 8.1 deprecations#40964

derrabus merged 1 commit intosymfony:4.4fromjrmajor:php81/http-foundation

Apr 27, 2021

Conversation

Copy link

Contributor

jrmajor commentedApr 27, 2021

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Fixes passingnull to non-nullable arguments.

carsonbot added Status: Needs Review Bug HttpFoundation labels

Apr 27, 2021

carsonbot added this to the4.4 milestone

Apr 27, 2021

Copy link

carsonbot commentedApr 27, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

jrmajor commented

Apr 27, 2021

View reviewed changes

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

		{
		returnarray_merge(
		[[null, [null,'unexistent-mime-type']]],
		[[null, ['unexistent-mime-type']]],

Copy link

ContributorAuthor

jrmajorApr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Request::getFormat() does not acceptnull:

symfony/src/Symfony/Component/HttpFoundation/Request.php

Lines 1308 to 1315 inb306bdb

	/**
	* Gets the format associated with the mime type.
	*
	* @param string $mimeType The associated mime type
	*
	* @return string\|null The format (null if not found)
	*/
	publicfunctiongetFormat($mimeType)