Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Fix tests with@doesNotPerformAssertions annotations#40957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexpott
Copy link
Contributor

@alexpottalexpott commentedApr 27, 2021
edited by OskarStark
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

If a test uses the@doesNotPerformAssertions and also has the Symfony Deprecation listener enabled because it is using the trait as well then this does not work as expected. Currently the bridge is checking this annotation/setting prior to running the test. This results in:

  • Tests not working as expected when$this->expectNotToPerformAssertions() is called during a test
  • If this is being used to ensure that a test does not perform an assertion then due to the bridge the test will no longer be marked as risky because we call$test->getTestResultObject()->beStrictAboutTestsThatDoNotTestAnything(false);

@carsonbotcarsonbot changed the titleFix tests with @doesNotPerformAssertions annotations[PhpUnitBridge] Fix tests with @doesNotPerformAssertions annotationsApr 27, 2021
@carsonbot
Copy link

Hey!

I think@fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@OskarStarkOskarStark changed the title[PhpUnitBridge] Fix tests with @doesNotPerformAssertions annotations[PhpUnitBridge] Fix tests with@doesNotPerformAssertions annotationsApr 29, 2021
@nicolas-grekasnicolas-grekas added this to the5.2 milestoneMay 7, 2021
@nicolas-grekas
Copy link
Member

Thank you@alexpott.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@alexpott@carsonbot@nicolas-grekas@OskarStark@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp