Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo] PhpDocExtractor: Handle "true" and "false" property types#40943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@maciejzgadzaj
Copy link

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40942
LicenseMIT
Doc PR

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add a test please?

derrabus reacted with thumbs up emoji
@maciejzgadzajmaciejzgadzajforce-pushed thephpdocextractor-true-false-property-types branch from5ae54d2 tob7658aaCompareApril 25, 2021 09:56
@maciejzgadzaj
Copy link
Author

Sure thing, wanted to make sure that this is the correct direction first.

Tests added.

@carsonbotcarsonbot changed the titlePhpDocExtractor: Handle "true" and "false" property types[PropertyInfo] PhpDocExtractor: Handle "true" and "false" property typesMay 7, 2021
@nicolas-grekas
Copy link
Member

Thank you@maciejzgadzaj.

maciejzgadzaj reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit72cc666 intosymfony:5.2May 7, 2021
This was referencedMay 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@maciejzgadzaj@carsonbot@nicolas-grekas@dunglas

[8]ページ先頭

©2009-2025 Movatter.jp