Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] PhpDocExtractor: Handle "true" and "false" property types#40943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[PropertyInfo] PhpDocExtractor: Handle "true" and "false" property types#40943
Uh oh!
There was an error while loading.Please reload this page.
Conversation
maciejzgadzaj commentedApr 24, 2021
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#40942 |
| License | MIT |
| Doc PR |
carsonbot commentedApr 24, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
dunglas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you add a test please?
5ae54d2 tob7658aaComparemaciejzgadzaj commentedApr 25, 2021
Sure thing, wanted to make sure that this is the correct direction first. Tests added. |
nicolas-grekas commentedMay 7, 2021
Thank you@maciejzgadzaj. |