Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Added PoEditor Provider#40926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@welcoMattic
Copy link
Member

@welcoMatticwelcoMattic commentedApr 23, 2021•
edited
Loading

QA
Branch?5.x
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#15310

To follow up on#38475, this PR addsPoEditor Provider.

The todo list to make it ready is:

  • Apply recent changes that have been made onProviderInterface andTranslatorBagInterface (we removed theall() andgetDomains() method from TranslatorBagInterface)
  • Add PoEditorProvider tosrc/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.php file
  • Add PoEditor case toSymfony\Component\Translation\Exception\UnsupportedSchemeException
  • Write integration tests by mocking HTTP Responses

The major part of the remaining work concerns tests, I will make it done before the beginning of May.

@carsonbot
Copy link

Please note that you need squash your commits before this PR can be merged. The maintainer can also squash the commits for you, but then you need to “Allow edits from maintainer” (there is a checkbox in the sidebar of the PR).

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas added this to the5.3 milestoneApr 23, 2021
@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 4 times, most recently from363ff30 to3fbeb16CompareApril 23, 2021 15:25
@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 2 times, most recently fromcd050d5 to0ab9d41CompareApril 26, 2021 20:18
@welcoMattic
Copy link
MemberAuthor

Package / Verify check fails now, it will be fixed as soon as#40928 will be merged.

@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 4 times, most recently froma50035f to32e25a0CompareApril 27, 2021 14:43
@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 2 times, most recently from4952323 to63b9b51CompareApril 27, 2021 15:58
@welcoMattic
Copy link
MemberAuthor

It ready for me for a review.
cc@OskarStark@Nyholm@nicolas-grekas

@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 4 times, most recently from700b7f3 to3d39d82CompareMay 1, 2021 16:29
@fabpot
Copy link
Member

Tests seem broken.

@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch from25bab11 to7568332CompareMay 9, 2021 16:13
@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch 2 times, most recently from865cb70 to3b1c532CompareMay 10, 2021 09:54
@welcoMatticwelcoMatticforce-pushed thefeature/poeditor-provider branch from3b1c532 to240ac22CompareMay 10, 2021 09:59

* Add`translation:pull` and`translation:push` commands to manage translations with third-party providers
* Add`TranslatorBagInterface::getCatalogues` method
* Add support to load XLIFF string in`XliffFileLoader`
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fabpot I've added those missing changes here

@welcoMattic
Copy link
MemberAuthor

Last comments have been addressed, branch has been rebased

@fabpot
Copy link
Member

Thank you@welcoMattic.

@fabpotfabpot merged commitaf19b6b intosymfony:5.xMay 10, 2021
@welcoMatticwelcoMattic deleted the feature/poeditor-provider branchMay 10, 2021 10:13
@fabpotfabpot mentioned this pull requestMay 12, 2021
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMay 19, 2021
This PR was submitted for the 5.4 branch but it was squashed and merged into the 5.3 branch instead.Discussion----------[Translation] Introduce Translation ProvidersDocs forsymfony/symfony#38475,symfony/symfony#40926,symfony/symfony#40927, andsymfony/symfony#40947Ready for first review, but I'm not sure that I've written documentation in the right and all required places.ATM, Translation Providers Bridges packages doesn't exists, so Flex recipes are not created yet.Commits-------943a63f [Translation] Introduce Translation Providers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

6 participants

@welcoMattic@carsonbot@fabpot@nicolas-grekas@stof@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp