Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PasswordHasher] accept hashing passwords with nul bytes or longer than 72 bytes when using bcrypt#40920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f927b8e to2acae1dComparechalasr previously approved these changesApr 23, 2021
rosier suggested changesApr 28, 2021
Uh oh!
There was an error while loading.Please reload this page.
chalasr requested changesApr 28, 2021
Member
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some tests are broken
MemberAuthor
nicolas-grekas commentedApr 29, 2021
Green! Status: needs review |
…an 72 bytes when using bcrypt
chalasr added a commit that referenced this pull requestApr 29, 2021
…s-grekas)This PR was merged into the 4.4 branch.Discussion----------[Security] [Security/Core] fix checking for bcrypt| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Spotted while working on#40920Because of the logic in the constructor, if bcrypt is used, it's not cast to string.Commits-------f01ea99 [Security/Core] fix checking for bcrypt
chalasr approved these changesApr 29, 2021
Member
chalasr commentedApr 29, 2021
Thank you@nicolas-grekas. |
Merged
12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This limitation of bcrypt creates a risk for migrations. But we can remove it, so here we are.