Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config][DependencyInjection] Uniformize trailing slash handling#40917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@dunglas
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

Currently, the handling of trailing slashes in file loaders exclusion rules is inconsistent, which can create hard to debug issues.

Example:

services:App\:resource:'../src/'exclude:# This works            -'../src/FooBar/DependencyInjection/'            -'../src/FooBar/DependencyInjection'            -'../src/FooBar/DependencyInjection/*'            -'../src/*/DependencyInjection'            -'../src/*/DependencyInjection/*'# This doesn't work            -'../src/*/DependencyInjection/'

This PR fixes this subtle issue.

Nyholm reacted with thumbs up emoji
@carsonbotcarsonbot added this to the4.4 milestoneApr 22, 2021
@carsonbotcarsonbot changed the title[DependencyInjection][Config] Uniformize trailing slash handling[Config][DependencyInjection] Uniformize trailing slash handlingApr 22, 2021
@dunglasdunglasforce-pushed thefix/exclude-trailing-slash branch from05e6278 to0a39dd1CompareApril 22, 2021 22:56
@carsonbot
Copy link

Hey!

I think@tristanbes has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekasforce-pushed thefix/exclude-trailing-slash branch fromddcfae9 todc50aa3CompareMay 7, 2021 13:38
@nicolas-grekas
Copy link
Member

Thank you@dunglas.

@nicolas-grekasnicolas-grekas merged commit0e738ef intosymfony:4.4May 7, 2021
This was referencedMay 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@dunglas@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp