Whenwriting documentation we found that we don't really support environment variables in the leaves. Ie, we expect a boolean but you provide"%env(ENABLE_FOO)%"

This PR will also introduceParamConfigurator to allow parameters to be passed as config.

The changes to the generated code:

    /**+    * @param bool|ParamConfigurator $value     * @default false     * @return $this     */-   public function enabled(bool $value): self+   public function enabled($value): self    {        $this->enabled = $value;            return $this;    }

carsonbot added Status: Needs Review Bug Config labels

Apr 22, 2021

Copy link

Member

nicolas-grekas commentedApr 22, 2021

This makes me realize that any%param% could also be allowed there, not only env ones.
This means we need to add a ParamConfigurator, and that EnvConfigurator should extend it.
Then, the param() function should return a ParamConfigurator.

nicolas-grekas added this to the5.3 milestone

Apr 22, 2021

nicolas-grekas reviewed

Apr 22, 2021

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Apr 22, 2021

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ParamConfigurator.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Apr 22, 2021

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/ParamConfigurator.php OutdatedShow resolvedHide resolved

stof requested changes

Apr 22, 2021

View reviewed changes

src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Apr 22, 2021

Nyholm force-pushed theenv-support branch from5fc6c55 tocad2529Compare

April 22, 2021 10:19

Copy link

MemberAuthor

Nyholm commentedApr 22, 2021•
edited
Loading

I cannot figure out why I get this error:

1) Symfony\Component\Config\Tests\Builder\GeneratedConfigTest::testConfig with data set "Placeholders" ('Placeholders', 'placeholders')Error: Call to undefined function Symfony\Component\DependencyInjection\Loader\Configurator\env()src/Symfony/Component/Config/Tests/Builder/Fixtures/Placeholders.config.php:7src/Symfony/Component/Config/Tests/Builder/GeneratedConfigTest.php:50

Nyholm mentioned this pull request

Apr 22, 2021

[ConfigBuilder] Replace all framework configsymfony/symfony-docs#15269

Merged

Copy link

Member

nicolas-grekas commentedApr 22, 2021•
edited
Loading

That's because the function is not autoloaded. This means that we should force-load ContainerConfigurator in the loader.

Copy link

MemberAuthor

Nyholm commentedApr 22, 2021•
edited
Loading

I tried that before, but I failed "force loading it". Hm.. it works now. I think I have to blame this on incompetence.

But this means that a user will have the same issues. Before the ConfigBuilders, this was not an issue because the user would always useContainerConfigurator.