Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config] Use plural name on array values#40878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.xfromNyholm:config-plural-name
Apr 21, 2021

Conversation

@Nyholm
Copy link
Member

@NyholmNyholm commentedApr 19, 2021•
edited
Loading

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PRRelated:symfony/symfony-docs#15264

If we have a PrototypedArrayNode and the prototype is does not have a key (->useAttributeAsKey('name')). Then we know for sure that the value should be an array.

See this example from$framework->assets()

    /**+    * @param list<mixed>     * @return $this     */-   public function baseUrl($value): self+   public function baseUrls(array $value): self    {        $this->baseUrls = $value;            return $this;    }

Nyholm added a commit to Nyholm/sf-issue-40600 that referenced this pull requestApr 19, 2021
@NyholmNyholm added this to the5.3 milestoneApr 20, 2021
@Nyholm
Copy link
MemberAuthor

This is a small BC break in the generated code added in 5.3-beta1

@nicolas-grekas
Copy link
Member

Thank you@Nyholm.

@nicolas-grekasnicolas-grekas merged commitf82c118 intosymfony:5.xApr 21, 2021
@Nyholm
Copy link
MemberAuthor

Thank you for the reviews and the merge!

@NyholmNyholm deleted the config-plural-name branchApril 21, 2021 09:23
@fabpotfabpot mentioned this pull requestMay 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Nyholm@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp