Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Config] Make sure one can build cache on Windows and then run in (Docker) Linux#40877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.xfromNyholm:config-windows
Apr 21, 2021

Conversation

@Nyholm
Copy link
Member

QA
Branch?5.x
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

The generated ConfigBuilders should use the\DirectorySeparator constant. The resulting string will look like this:

<?phpnamespaceSymfony\Config;require_once__DIR__.\DIRECTORY_SEPARATOR.'Twig'.\DIRECTORY_SEPARATOR.'GlobalConfig.php';require_once__DIR__.\DIRECTORY_SEPARATOR.'Twig'.\DIRECTORY_SEPARATOR.'DateConfig.php';require_once__DIR__.\DIRECTORY_SEPARATOR.'Twig'.\DIRECTORY_SEPARATOR.'NumberFormatConfig.php';/** * This class is automatically generated to help creating config. * * @experimental in 5.3 */class TwigConfigimplements \Symfony\Component\Config\Builder\ConfigBuilderInterface{private$formThemes;

@stof
Copy link
Member

or just use/ all the time ?

fabpot reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 20, 2021
edited
Loading

or just use / all the time ?

We use DIRECTORY_SEPARATOR also in the dumped container. I think this saves a lookup in the realpath_cache.

See eg#38139

@nicolas-grekasnicolas-grekas added this to the5.3 milestoneApr 20, 2021
@nicolas-grekas
Copy link
Member

Thank you@Nyholm.

@nicolas-grekasnicolas-grekas merged commit71c6c42 intosymfony:5.xApr 21, 2021
@NyholmNyholm deleted the config-windows branchApril 21, 2021 09:11
@Nyholm
Copy link
MemberAuthor

Thank you for merging

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Nyholm@stof@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp