Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] fix attribute namespace with recursive traits#40874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[PropertyInfo] fix attribute namespace with recursive traits#40874
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| } | ||
| try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note: I moved the login out thetry/catch block because as far as I know, this statement is for the$this->docBlockFactory->create line below, not for the recursive resolution.
Please tell me if I'm wrong. 👍
src/Symfony/Component/PropertyInfo/Tests/Fixtures/TraitUsage/DummyTrait.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1be04b8 tobbadfb3Comparenicolas-grekas commentedMay 7, 2021
Thank you@soullivaneuh. |
Uh oh!
There was an error while loading.Please reload this page.
The targeted issue is closed because considered as solved by#40175.
However, the fix is not enough and is not working with recursive trait inclusion. (see#36997 (comment)).
This pull request is completing the first fix of@xabbuh, trying to follow the same coding style. 😉