Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Add BackedEnumNormalizer#40831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add support for PHP 8.1 enums. Add tests.
carsonbot commentedApr 15, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedApr 16, 2021
Hey! I think@xfifix has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
stof commentedApr 16, 2021
@moinhussain unfortunately, another PR was opened half an hour before yours at#40830. As the other one is already under active review, I'm closing this one as duplicate. |
Add support for PHP 8.1 enums