Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
RequestMatcher issue when_controller is a closure#40807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_controller is a closure_controller is a closurecarsonbot commentedApr 14, 2021
Hey! I think@a-menshchikov has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas approved these changesApr 14, 2021
_controller is a closure_controller is a closuresrc/Symfony/Component/HttpFoundation/Tests/RequestMatcherTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesApr 15, 2021
Member
Nyholm commentedApr 15, 2021
Lovely, thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the
matchesmethod ofRequestMatcheris used on an attribute which is a closure it crashes.How did we get it
On a project that is using FOS HTTP Cache, we have this configuration
Everything works fine unless you are reaching a controller that is a closure.
You get a
TypeError: preg_match(): Argument #2 ($subject) must be of type string, Closure givenwhich is to me logical.Proposed solution
Just testing the type of attribute value and return false before crashing
preg_matchThis PR adds a quick unit test to enforce this.