Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder#40804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.xfromNyholm:config-warmer
Apr 14, 2021

Conversation

@Nyholm
Copy link
Member

QA
Branch?5.x
Bug fix?no
New feature?yes
Deprecations?
Tickets
LicenseMIT
Doc PR

Make sure ConfigBuilder exists before you write your first line of config.

This is similar to#40803

$this->dumpExtension($extension,$generator);
}catch (\Throwable$e) {
if ($this->logger) {
$this->logger->warning('Failed to generate ConfigBuilder for extension {extensionClass).', ['exception' =>$e,'extensionClass' =>\get_class($extension)]);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If a (bundle) extension is using some syntax not supported by the generator builder, we dont want an exception when warming the cache. The user may not even be using the ConfigBuilder for that extension.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

s/{extensionClass)/{extensionClass}

@NyholmNyholm added the Ready labelApr 14, 2021
OskarStark added a commit that referenced this pull requestApr 14, 2021
…ebugContainerTrait::getContainerBuilder() (Nyholm)This PR was squashed before being merged into the 5.3-dev branch.Discussion----------[FrameworkBundle] Add argument KernelInterface to BuildDebugContainerTrait::getContainerBuilder()| Q             | A| ------------- | ---| Branch?       | 5.x| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |This comes from a suggestion by `@yceruto`#40804 (comment)This change will make the trait usable outside the `Command` namespace. I did not find a better namespace to move the trait to though.. This patch will help#40804The trait is internal so the change is okey.Commits-------0e9652a [FrameworkBundle] Add argument KernelInterface to BuildDebugContainerTrait::getContainerBuilder()
@nicolas-grekas
Copy link
Member

Thank you@Nyholm.

@Nyholm
Copy link
MemberAuthor

Awesome. :)

if ($extensioninstanceof ConfigurationInterface) {
$configuration =$extension;
}elseif ($extensioninstanceof ConfigurationExtensionInterface) {
$configuration =$extension->getConfiguration([],$this->getContainerBuilder($this->kernel));
Copy link
Contributor

@stephanvierkantstephanvierkantApr 18, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

$extension->getConfiguration() can returnnull, while$generator->build() doesn't acceptnull. Seedoctrine/DoctrineFixturesBundle#349.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for testing prereleases! This will be fixed by#40859

stephanvierkant reacted with hooray emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@stephanvierkantstephanvierkantstephanvierkant left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@Nyholm@nicolas-grekas@stephanvierkant@wouterj@OskarStark@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp