Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Add command to dump ConfigBuilders#40803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6b6ab01 toec518e1Comparero0NL commentedApr 13, 2021
cant we dump along when the container is dumped? Im not sure one should ever call this command 🤔 IIUC configuration classes are already resource tracked, thus reloaded on change. |
nicolas-grekas commentedApr 13, 2021
Since we strive to reduce the list of default commands, I'm not sure we need this command. Cache warmers are enough to me. |
Nyholm commentedApr 13, 2021
Thank you both for your input. Im closing this PR in favour of#40804 |
…ilder (Nyholm)This PR was squashed before being merged into the 5.3-dev branch.Discussion----------[Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | no| New feature? | yes| Deprecations? || Tickets || License | MIT| Doc PR |Make sure ConfigBuilder exists before you write your first line of config.This is similar to#40803Commits-------c1d6c0e [Config][FrameworkBundle] Add CacheWarmer for ConfigBuilder
Uh oh!
There was an error while loading.Please reload this page.
This will add a command
config:dump-buildersthat you can force to dump ConfigBuilders.We can discuss if this is needed if we have a cache warmer. Ie, then the ConfigBuilders will be generated on
cache:warmup. See#40804