Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Deprecate using UsageTrackingTokenStorage outside the request-response cycle#40785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.xfromwouterj:issue-40778/usage-tracking-token-storageApr 13, 2021
Merged
[Security] Deprecate using UsageTrackingTokenStorage outside the request-response cycle#40785
fabpot merged 1 commit intosymfony:5.xfromwouterj:issue-40778/usage-tracking-token-storageApr 13, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/Security/Core/Authentication/Token/Storage/UsageTrackingTokenStorage.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
6ecdbf7 to53aa87bComparejderusse approved these changesApr 12, 2021
UPGRADE-5.3.md Outdated
| Security | ||
| -------- | ||
| * Deprecate using`UsageTrackingTokenStorage` with tracking enabled without a main request. Use the untracking token |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| * Deprecate using`UsageTrackingTokenStorage` with tracking enabled without a main request. Use theuntracking token | |
| * Deprecate using`UsageTrackingTokenStorage` with tracking enabled without a main request. Use theuntracked token |
fabpot approved these changesApr 13, 2021
53aa87b to7452476CompareMember
fabpot commentedApr 13, 2021
Thank you@wouterj. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, you get an "There is currently no session available" exception when using the
security.token_storageservice outside the main request-response cycle (e.g. in akernel.terminatelistener). This PR deprecates such usage and requires developers to update their definitions to explicitly usesecurity.untracked_token_storageinstead.A different solution would be to silently disable tracking in these cases, but I think that might create some unnecessary technical debt.