Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix/Implement recursive Finder::ignoreVCSIgnored filter#40769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mvorisek wants to merge2 commits intosymfony:5.4frommvorisek:gitignore_full

Conversation

@mvorisek
Copy link
Contributor

@mvorisekmvorisek commentedApr 11, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#37781
LicenseMIT
Doc PRno

@carsonbotcarsonbot added this to the4.4 milestoneApr 11, 2021
@mvorisekmvorisekforce-pushed thegitignore_full branch 4 times, most recently from6fa953b to884af41CompareApril 12, 2021 11:59
@carsonbot
Copy link

Hey!

I think@hurricane-voronin has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@mvorisekmvorisekforce-pushed thegitignore_full branch 3 times, most recently fromf1862d0 to8a5de63CompareApril 16, 2021 07:35
@fabpot
Copy link
Member

It can be seen as a bug fix, but this is a new feature according to the way we think about versionning. So, this must target 5.4 instead of 4.4. Thank you.

@fabpotfabpot modified the milestones:4.4,5.4Aug 26, 2021
@mvorisekmvorisek changed the base branch from4.4 to5.4August 26, 2021 19:24
@mvorisek
Copy link
ContributorAuthor

#43150 provided this functionality, I will submit another PR to add the relativize method.

@mvorisekmvorisek deleted the gitignore_full branchSeptember 29, 2021 23:02
@mvorisekmvorisek restored the gitignore_full branchSeptember 29, 2021 23:02
@mvorisekmvorisek deleted the gitignore_full branchSeptember 29, 2021 23:02
@mvorisekmvorisek restored the gitignore_full branchSeptember 29, 2021 23:04
@mvorisekmvorisek deleted the gitignore_full branchNovember 1, 2021 12:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

Finder ->ignoreVCSIgnored(true) doesn't do what it claims

3 participants

@mvorisek@carsonbot@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp