Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix/Rewrite .gitignore regex builder#40763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frommvorisek:fix_wildcard_gitignore
May 9, 2021

Conversation

@mvorisek
Copy link
Contributor

@mvorisekmvorisek commentedApr 10, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsfix#39257
LicenseMIT
Doc PRno

This PR fixes.gitignore with exclude wildcard ignore rules like!a/*/b were failing withpreg_match(): Compilation failed: lookbehind assertion is not fixed length at offset PHP error.

Functionality/performance was verified against large.gitignore files:

This PR also improves the testing cases.

Jeroeny reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@mvorisekmvorisek changed the titleWIP Fix wildcard gitignoreWIP Fix gitignore regex generator for exclude rules with wildcardApr 10, 2021
@mvorisekmvorisek changed the titleWIP Fix gitignore regex generator for exclude rules with wildcardWIP Rewrite gitignore regex generatorApr 11, 2021
@mvorisekmvorisek changed the titleWIP Rewrite gitignore regex generatorWIP Fix/Rewrite gitignore regex builderApr 11, 2021
@mvorisekmvorisek changed the titleWIP Fix/Rewrite gitignore regex builderFix/Rewrite gitignore regex builderApr 11, 2021
@mvorisekmvorisek changed the titleFix/Rewrite gitignore regex builderFix/Rewrite .gitignore regex builderApr 11, 2021
@mvorisekmvorisek reopened thisApr 11, 2021
@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch 2 times, most recently from0e4daff tocbc233dCompareApril 11, 2021 11:42
@mvorisekmvorisek marked this pull request as ready for reviewApril 11, 2021 11:42
@carsonbotcarsonbot added this to the4.4 milestoneApr 11, 2021
@mvorisekmvorisek changed the titleFix/Rewrite .gitignore regex builder[Finder] Fix/Rewrite .gitignore regex builderApr 11, 2021
@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch 2 times, most recently frombd5de06 tod530c6dCompareApril 11, 2021 12:00
@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch frome102f96 to883450eCompareApril 11, 2021 12:33
@carsonbot
Copy link

Hey!

I think@hurricane-voronin has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch 5 times, most recently frome859ae5 to31c3f57CompareApril 12, 2021 11:43
@mvorisekmvorisek requested a review fromjderusseApril 12, 2021 11:43
@Jeroeny
Copy link
Contributor

With.gitignore:

/config/**!/config/packages!/config/packages/something.yaml

It seems to give an invalid result:
given:config/packages/foo.yaml
actual: git-ignored
regex result: 0 (no match, not git-ignored)

@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch fromd5232c4 toa3d89b6CompareApril 13, 2021 10:45
@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch 6 times, most recently from8d1b903 to5a7f2a5CompareApril 13, 2021 13:07
@mvorisek
Copy link
ContributorAuthor

mvorisek commentedApr 13, 2021•
edited
Loading

@Jeroeny/config/** rule was wrongly "canceled" by!/config/packages rule. Now fixed in13179f8.

Jeroeny reacted with thumbs up emoji

@mvorisekmvorisek requested a review fromstofApril 13, 2021 13:11
@mvorisekmvorisekforce-pushed thefix_wildcard_gitignore branch 2 times, most recently froma6f61eb to331be37CompareApril 16, 2021 07:35
@mvorisek
Copy link
ContributorAuthor

This PR is hanging here for 3 weeks, AppVeyor build error is irrelevant, can someone please review it?

@carsonbotcarsonbot changed the title[Finder] Fix/Rewrite .gitignore regex builderFix/Rewrite .gitignore regex builderMay 9, 2021
@fabpotfabpotforce-pushed thefix_wildcard_gitignore branch from331be37 to83f9fd3CompareMay 9, 2021 09:13
@fabpot
Copy link
Member

Thank you@mvorisek.

@fabpotfabpot merged commitbe480d8 intosymfony:4.4May 9, 2021
@mvorisekmvorisek deleted the fix_wildcard_gitignore branchMay 9, 2021 09:18
This was referencedMay 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@jderussejderusseAwaiting requested review from jderusse

@stofstofAwaiting requested review from stof

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@mvorisek@carsonbot@Jeroeny@fabpot@stof@jderusse@maxhelias
[8]ページ先頭
©2009-2025 Movatter.jp