NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Simplified condition and removed unused code from AbstractSessionListener::onKernelRequest#40760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromStefanoCappellini:clear_onKernelRequest

Apr 11, 2021

Merged

Simplified condition and removed unused code from AbstractSessionListener::onKernelRequest#40760

nicolas-grekas merged 1 commit intosymfony:4.4fromStefanoCappellini:clear_onKernelRequest

Apr 11, 2021

Conversation

Copy link

Contributor

StefanoCappellini commentedApr 10, 2021•
edited by nicolas-grekas
Loading

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	None
License	MIT

This PR simplifies a condition and removes unused code (AFAIK coming from#38894)).

carsonbot added the Status: Needs Review label

Apr 10, 2021

Copy link

carsonbot commentedApr 10, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot