Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FORM] Add option grouping in TimezoneType#40757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
add in the options the grouping, which allows group according to the continents.
carsonbot commentedApr 10, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
add grouping by continent for (getPhpTimezones and getIntlTimezones) to activate grouping, add the "grouping" parameters to true in the options
ro0NL commentedApr 10, 2021
such grouping was intentionaly reverted in#31293, in favor of existing |
Add other group
arvodia commentedApr 10, 2021
performance and display is better than "group_by" |
add in the options the grouping, which allows group according to the continents.