Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FORM] Add option grouping in TimezoneType#40757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
arvodia wants to merge4 commits intosymfony:5.xfromarvodia:patch-1
Closed

[FORM] Add option grouping in TimezoneType#40757

arvodia wants to merge4 commits intosymfony:5.xfromarvodia:patch-1

Conversation

@arvodia
Copy link

add in the options the grouping, which allows group according to the continents.

QA
Branch?5.x for features
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#...

add in the options the grouping, which allows group according to the continents.
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

add grouping by continent for (getPhpTimezones and getIntlTimezones) to activate grouping, add the "grouping" parameters to true in the options
@ro0NL
Copy link
Contributor

such grouping was intentionaly reverted in#31293, in favor of existinggroup_by. Im not sure we should introducinggrouping now.

Nyholm reacted with thumbs up emoji

@arvodiaarvodia changed the titleUpdate TimezoneType.php[Form] Update TimezoneType.phpApr 10, 2021
@arvodiaarvodia changed the title[Form] Update TimezoneType.php[FORM] Add option grouping in TimezoneTypeApr 10, 2021
@arvodia
Copy link
Author

performance and display is better than "group_by"

@arvodiaarvodia deleted the patch-1 branchApril 10, 2021 16:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arvodia@carsonbot@ro0NL

[8]ページ先頭

©2009-2025 Movatter.jp