Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
allow null for framework.translator.default_path#40744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ro0NL commentedApr 8, 2021
shouldnt we fix it at the Configuration level, given IIUC |
SimonHeimberg commentedApr 8, 2021
I see two options:
I am not sure which way to go. Actually it was a BC break in 3.4.x, which was not noticed quickly. For more details see#37111 |
ro0NL commentedApr 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
i think it broke as of 4.x due the added type hint in ContainerBuilder::fileExists before the inexistence was implicit, eg. So i think allowing explicit |
SimonHeimberg commentedApr 9, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Should I add a test case checking this config value? Where should I add it? I doubt that |
Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility).fixessymfony#37111
fabpot commentedAug 26, 2021
Thank you@SimonHeimberg. |
Uh oh!
There was an error while loading.Please reload this page.
Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility).