Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Add options to Microsoft Teams notifier#40738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/AbstractMicrosoftTeamsAction.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/MicrosoftTeamsHttpPostAction.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/MicrosoftTeamsTransport.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...ny/Component/Notifier/Bridge/MicrosoftTeams/Section/AbstractMicrosoftTeamsSectionElement.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Section/AbstractMicrosoftTeamsSection.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...y/Component/Notifier/Bridge/MicrosoftTeams/Section/MicrosoftTeamsSectionElementInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
14eea2a to920961eComparesrc/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/ActionCardAction.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
4a18dd8 toa3e9511Comparedd69d4d to38c7a69Compare38c7a69 tod22a391Compare
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you. This looks way better now.
I've not tested the code, but I trust that you have.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/MicrosoftTeamsOptions.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/MicrosoftTeamsTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
d89f4b5 to767698eComparesrc/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/ActionCardAction.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...fony/Component/Notifier/Bridge/MicrosoftTeams/Action/ActionCardCompatibleActionInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/ActionElementInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Section/FieldInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
95129e9 tod997961Compare
chalasr left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems that some interfaces are not actually needed.
Interfaces make maintenance harder so it must be worth it. I strongly think those should be removed, we can reconsider later if a use case comes out.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/Element/ActionElementInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Section/Field/FieldInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
d997961 to3fc7247Compare57c793d to0039b9cCompare4d275c8 tod86f7b4Compare
jderusse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not a big fan of the protectedoptions and everybody writing into it.
I wonder if the property shouldn't be private, and each class is responsible for its own properties. Then change thetoArray method for something like
publicfunctiontoArray():array{returnparent::toArray() +$this->options + ['@action' =>'FooBar'];}
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/ActionCard.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/MicrosoftTeams/Action/Element/Header.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedJun 17, 2021
@jderusse makes sense, did that 👍 |
96d3019 toe33faaeComparee33faae tod039ce7Comparefabpot commentedJun 23, 2021
Thank you@OskarStark. |
…milKubicki)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Notifier] Documentation for Microsoft Teams OptionsDocs forsymfony/symfony#40738Replaces#15232Commits-------3c98ba8 [Notifier] Documentation for Microsoft Teams Options
Uh oh!
There was an error while loading.Please reload this page.
After rework: