Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Fix 'invalid_message' use in multiple ChoiceType#40660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexandre-daubois
Copy link
Member

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40636
LicenseMIT
Doc PR

invalid_message option were not take into account anymore since v5.2.4. This PR intends to fix this. The optioninvalid_message is now passed to thePOST_SUBMIT callback, for multiple ChoiceType.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@alexandre-dauboisalexandre-dauboisforce-pushed thefix-ignored-invalid-message-on-multiple-choice-type branch from7e04d32 toe3c3795CompareMarch 31, 2021 17:32
@nicolas-grekasnicolas-grekas added this to the5.2 milestoneApr 1, 2021
@nicolas-grekasnicolas-grekas changed the base branch from5.x to5.2April 1, 2021 09:18
@nicolas-grekasnicolas-grekas changed the base branch from5.2 to5.xApril 1, 2021 09:18
@nicolas-grekasnicolas-grekas changed the base branch from5.x to5.2April 1, 2021 09:20
@nicolas-grekasnicolas-grekasforce-pushed thefix-ignored-invalid-message-on-multiple-choice-type branch frome3c3795 tocaf7a3fCompareApril 1, 2021 09:20
@nicolas-grekasnicolas-grekasforce-pushed thefix-ignored-invalid-message-on-multiple-choice-type branch fromcaf7a3f tof251684CompareApril 1, 2021 09:51
@Nyholm
Copy link
Member

Awesome. Well done!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

'invalid_message' has no more effect on 'ChoiceType' with option 'multiple'

5 participants

@alexandre-daubois@carsonbot@Nyholm@nicolas-grekas@yceruto
[8]ページ先頭
©2009-2025 Movatter.jp