Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][HttpKernel][TwigBundle] Bundle templates and translations configuration#40631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMar 29, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
yceruto commentedMar 29, 2021
Hello@kumulo, thanks for contributing. For the record, this kind of proposal has been rejected in the past:#32845 (comment)
And I still agree with him, thus 👎 on my side. On the other hand, I don't think it's so hard to achieve by implementing publicfunctionprepend(ContainerBuilder$container):void{$container->prependExtensionConfig('twig', ['paths' => ['/<bundle_path>/custom_path/templates' =>'Custom', ], ]);$container->prependExtensionConfig('framework', ['translator' => ['paths' => ['/<bundle_path>/custom_path/translations', ], ], ]);} |
kumulo commentedMar 29, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello@yceruto |
Makes bundle templates and translations directory depending of bundle configuration, not Kernel
In DDD pattern and hexagonal architecture for bundles, I was faced to symfony tree model for translations and templates.
This PR allows to define bundle's translations and templates directories in bundle itself, instead of numerous lines of code in dependencies injections.