Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] fix docblock#40611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMar 28, 2021
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
5220f51 toda181fcComparexabbuh commentedMar 28, 2021
This fixes tests where the code is patched to have real return type declarations. |
Nyholm commentedMar 28, 2021
I think you are referring to this PR#40535 But I dont see how your fix solves the build. Could you please elaborate? |
| * Returns true if the debug is enabled. | ||
| * | ||
| * @return bool true if debug is enabled, false otherwise | ||
| * @return bool|string true if debug is enabled, false otherwise or a string if no kernel was set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this better?
| * @return bool|string trueif debug is enabled, false otherwiseor a stringif no kernel was set | |
| * @return bool|'n/a' trueif debug is enabled, false otherwiseor a stringif no kernel was set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
n/a is not a valid type I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
n/ais not a valid type I think
'n/a' is a literal type. PHPStan and Psalm support literal types, but I'm not aware that we've ever used them in the Symfony codebase.
xabbuh commentedMar 28, 2021
@Nyholm In the pipeline we have a job that patches our code to add real return type declarations. Which means here that when |
Nyholm commentedMar 28, 2021
Oh. That is cool. I didn't know that. |
Nyholm commentedMar 28, 2021
Thank you |