Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] error if the input string couldn't be parsed as a date#40598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromxabbuh:issue-40597
Mar 28, 2021

Conversation

@xabbuh
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40597
LicenseMIT
Doc PR

When the Intl polyfill is used instead of the PHP intl extension, the
intl_get_error_code() function always returns 0 no matter if the input
string could be parsed.

When the Intl polyfill is used instead of the PHP intl extension, theintl_get_error_code() function always returns 0 no matter if the inputstring could be parsed.
@nicolas-grekas
Copy link
Member

Would there be a way to improve the polyfill in this regard?

Copy link

@kamil-jakubowskikamil-jakubowski left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That workaround works when using Symfony Intl Polyfill (with intl ext uninstalled) on Symfony 5.2
image

Although, there is a bug still in Symfony Intl Polyfill :)

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit5666a45 intosymfony:4.4Mar 28, 2021
@xabbuhxabbuh deleted the issue-40597 branchMarch 28, 2021 07:47
This was referencedMar 29, 2021
@xabbuh
Copy link
MemberAuthor

@kamil-jakubowski I was looking into fixing the Intl polyfill package, but I actually couldn't reproduce the behaviour that you experienced. Which exact version of the polyfill package do you use? Can you debug why the error code isn't stored correctly?

@emilylark

This comment was marked as spam.

@symfonysymfony deleted a comment fromemilylarkMay 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

+1 more reviewer

@kamil-jakubowskikamil-jakubowskikamil-jakubowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh@nicolas-grekas@fabpot@emilylark@OskarStark@kamil-jakubowski@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp