NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translation] Fix update existing key with existing +int-icu domain#40552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

axi wants to merge1 commit intosymfony:4.4fromsmiileTeam:4.4

Closed

[Translation] Fix update existing key with existing +int-icu domain#40552

axi wants to merge1 commit intosymfony:4.4fromsmiileTeam:4.4

Conversation

Copy link

axi commentedMar 23, 2021

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	none
License	MIT
Doc PR	none

Using php-translation webui interface, I was trying to update an existing +int-icu domain but a regular domain was created and the existing key wasn't updated. Looks like in the method I modified, we should have been looking for a potential domain+intl-icu domain and try update it first

[translation] Fix update existing key with existing +int-icu domain

1744297

carsonbot added Status: Needs Review Bug Translation labels

Mar 23, 2021

carsonbot added this to the4.4 milestone

Mar 23, 2021

Copy link

carsonbot commentedMar 23, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot changed the title~~[translation] Fix update existing key with existing +int-icu domain~~[Translation] Fix update existing key with existing +int-icu domain

Mar 23, 2021

stof approved these changes

Mar 23, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 23, 2021

nicolas-grekas approved these changes

Mar 23, 2021

View reviewed changes

Copy link

Member

nicolas-grekas commentedMar 23, 2021

Thank you@axi.

nicolas-grekas added a commit that referenced this pull request

Mar 23, 2021

bug#40552[Translation] Fix update existing key with existing +int-i…

1665555

…cu domain (Alexis)This PR was merged into the 4.4 branch.Discussion----------[Translation] Fix update existing key with existing +int-icu domain| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |  none| License       | MIT| Doc PR        | noneUsing php-translation webui interface, I was trying to update an existing +int-icu domain but a regular domain was created and the existing key wasn't updated. Looks like in the method I modified, we should have been looking for a potential domain+intl-icu domain and try update it firstCommits-------2a196ca [translation] Fix update existing key with existing +int-icu domain

nicolas-grekas closed this

Mar 23, 2021